iarc v2 "client" (bug 1228376, 1228374)#3459
iarc v2 "client" (bug 1228376, 1228374)#3459ngokevin wants to merge 4 commits intomozilla:masterfrom
Conversation
ngokevin
changed the title
|
failing test has a PR |
lib/iarc_v2/client.py
Outdated
There was a problem hiding this comment.
cert_uuid naming is not coherent with search_certs().
Also, I don't really like the action parameter, because it exposes to the outside world the underlying implementation.
There was a problem hiding this comment.
Regarding my previous comment about action : My plan was for the client to use the serializer from #3457, being high-level enough to be used by the webapp code, hiding IARC implementation from them. Your implementation is closer to a super-thin client. Were you planning on using it directly in webapp models/tasks ?
There was a problem hiding this comment.
i can make it so it uses the serializer. and i like hiding action, i'll split it out
|
Move my serializer and its tests to the new iarc_v2 folder you created while you're at it. |
|
the serializer will also be used by developers/views PushCerts. we can just have that import from lib/iarc_v2? |
|
Yeah |
|
@diox if it's not good by the time i'm online, feel free to fetch or merge and work off of it |
There was a problem hiding this comment.
Call this cert_id to be coherent with the rest.
|
Superseded by #3466 |
2 participants
No description provided.