This repository was archived by the owner on Mar 15, 2018. It is now read-only.
Implement IARCv2 PushCert API (bug 1228373)#3464
Merged
diox merged 1 commit intomozilla:masterfrom Dec 4, 2015
Merged
Conversation
Member
Author
mkt/developers/urls.py
Outdated
Contributor
There was a problem hiding this comment.
do we call it pushcerts and mention v2?
Member
Author
There was a problem hiding this comment.
Maybe yeah. Or just /iarc/pushcert/ ? I wanted to avoid the "v2" in the URL because it was confusing with our own API version number
diox
force-pushed
the
iarc-v2-pushcert
branch
2 times, most recently
from
38d5a59 to
626f3fd
Compare
Member
Author
|
@ngokevin updated, with tests. I'm not doing the |
Member
Author
There was a problem hiding this comment.
This is to make sure we're properly formatting the UUID before sending it to IARC through the questionnaire.
diox
force-pushed
the
iarc-v2-pushcert
branch
from
626f3fd to
2996d09
Compare
Contributor
|
some test issues |
Member
Author
|
Fixed the flake8 issue, tests are passing. |
Contributor
|
r+ |
diox
added a commit
that referenced
this pull request
Dec 4, 2015
Implement IARCv2 PushCert API (bug 1228373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready yet, missing tests and the code to store the Cert ID. I'm sharing this early to make sure we are on the same page.