demux_mkv: skip malformed TrackEntry elements - #18333
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
Contributor
|
Why is this a problem? There could be legitimate files with >256 tracks. |
The Matroska demuxer creates persistent track state even if a TrackEntry lacks mandatory fields. A malformed file can use a large list of such entries to consume memory while it is opened. Check TrackNumber, TrackUID, TrackType, and CodecID before creating per-track state. Valid files with large track counts retain their existing behavior.
acts-1631
force-pushed
the
limit-matroska-track-entries
branch
from
August 2, 2026 22:22
5c68134 to
7d69d5d
Compare
acts-1631
changed the title
Author
|
Good point. I dropped the count cap. The revised patch skips only TrackEntry records missing mandatory fields before creating persistent track state, so valid files with large track counts retain their existing behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed Matroska files can contain many TrackEntry elements without their
mandatory fields. The native demuxer creates persistent state for each entry
while opening the file, allowing unnecessary memory consumption.
Skip entries without TrackNumber, TrackUID, TrackType, or CodecID before
creating per-track state. Valid files with large track counts retain their
existing behavior.