Set camera.up vector as the orbit axis in OrbitControls #4530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4375. Previously, the orbit axis was hardwired to be the y-axis.
We'll see how this is received. Optionally, it could be limited to just
z-is-upandy-is-up, which I believe are the two cases of interest. By limiting the options, it would likely be easier to avoid edge cases, which may come up.Also added a new function that was required for this feature:
Quaternion.setFromUnitVectors( vFrom, vTo ), which sets the quaternion to the rotation required to rotate direction vectorvFromto direction vectorvTo.Finally, although unrelated,
TrackballControlswas generating too many change events. Fixed.ping @jasongrout
ping @ekatzenstein