Skip to content

add encodings support to unpack (compatible with msgpack-jruby)#25

Closed
technorama wants to merge 1 commit into
msgpack:masterfrom
technorama:master
Closed

add encodings support to unpack (compatible with msgpack-jruby)#25
technorama wants to merge 1 commit into
msgpack:masterfrom
technorama:master

Conversation

@technorama

Copy link
Copy Markdown

No description provided.

@frsyuki

frsyuki commented Dec 16, 2013

Copy link
Copy Markdown
Member

Why do you need this option? msgpack spec defines String type uses UTF-8: https://github.com/msgpack/msgpack/blob/master/spec.md#types

@technorama

Copy link
Copy Markdown
Author
  1. For compatibility with msgpack-jruby which accepts an identical encoding option.
  2. For sending binary data. Without this patch decoding doesn't give you the same string you encoded.
  3. The spec mentions sending binary data. This should be allowed.
  4. Provides a way for users to workaround bug Automatic UTF-8 string encoding in Ruby 1.9 can cause unexpected results #7
  5. Provides a way for users to workaround bug Unpack strings to ASCII-8Bit, not UTF-8 #40
  6. Provides a way to use this library with binary data until the spec handles binary data types/tagging in an unambiguous way.

@tagomoris

Copy link
Copy Markdown
Member

Now we are merging msgpack-jruby into this repository. So, I think that we don't have to take care about compatibility with it.
Please reopen this again if you have any concern about it.

@tagomoris tagomoris closed this May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants