Add wall time tiers and more wall time exit code#795
Merged
gongyixiao merged 5 commits intodevelopfrom May 14, 2020
Merged
Conversation
stevekm
reviewed
May 13, 2020
anoronh4
approved these changes
May 14, 2020
Collaborator
anoronh4
left a comment
There was a problem hiding this comment.
changes made sense and test on small data set ran without issues.
Member
|
I am testing it as well though my dataset is large so its takes a while to finish, however, it does look good so far and I cant see any errors coming up. Thanks so much this is great :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
params.wallTimeExitCodeis introduced to include140,0and1all as valid wall time limit exit code to trigger the bump up of the wall time tier when retry.