Skip to content

Add wall time tiers and more wall time exit code#795

Merged
gongyixiao merged 5 commits intodevelopfrom
feature/wallTime_tiers
May 14, 2020
Merged

Add wall time tiers and more wall time exit code#795
gongyixiao merged 5 commits intodevelopfrom
feature/wallTime_tiers

Conversation

@gongyixiao
Copy link
Copy Markdown
Collaborator

  1. Add wall time tiers parameters to support different SLA setting on juno
  2. Due to fixed bam truncation bug by using beforeScript and catch_USR2 #767 , this temporary solution for BAM truncation gives exit code 0 or 1 when USR2 was caught due to hitting the LSF time limit. So params.wallTimeExitCode is introduced to include 140, 0 and 1 all as valid wall time limit exit code to trigger the bump up of the wall time tier when retry.

@gongyixiao gongyixiao added the enhancement New feature or request label May 12, 2020
@gongyixiao gongyixiao added this to the 1.3.1 milestone May 12, 2020
@gongyixiao gongyixiao requested review from anoronh4 and stevekm May 12, 2020 20:39
@gongyixiao gongyixiao self-assigned this May 12, 2020
@gongyixiao gongyixiao changed the title add wallTime tiers and add more wall time exit code Add wallTime tiers and more wall time exit code May 12, 2020
@gongyixiao gongyixiao changed the title Add wallTime tiers and more wall time exit code Add wall time tiers and more wall time exit code May 12, 2020
Comment thread conf/juno.config
Copy link
Copy Markdown
Collaborator

@anoronh4 anoronh4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made sense and test on small data set ran without issues.

@gongyixiao gongyixiao merged commit e9383b7 into develop May 14, 2020
@gongyixiao gongyixiao deleted the feature/wallTime_tiers branch May 14, 2020 18:16
@stevekm
Copy link
Copy Markdown
Member

stevekm commented May 15, 2020

I am testing it as well though my dataset is large so its takes a while to finish, however, it does look good so far and I cant see any errors coming up. Thanks so much this is great :)

@gongyixiao gongyixiao mentioned this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants