Skip to content

Conversation

@simonyg
Copy link
Collaborator

@simonyg simonyg commented Jan 11, 2024

boost log NAMED_SCOPE cannot be used because the boost log is set up differently in the sink DLL. ExtractTimestamp transform has an inline code that uses NAMED_SCOPE..

ld: Undefined symbols:
boost::log::v2_mt_posix::attributes::named_scope::push_scope(boost::log::v2_mt_posix::attributes::named_scope_entry const&), referenced from:
boost::log::v2_mt_posix::attributes::named_scope::sentry::sentry(boost::log::v2_mt_posix::basic_string_literal<char, std::__1::char_traits> const&, boost::log::v2_mt_posix::basic_string_literal<char, std::__1::char_traits> const&, unsigned int, boost::log::v2_mt_posix::attributes::named_scope_entry::scope_name_type) in

@simonyg simonyg requested a review from wsobel January 11, 2024 08:00
Copy link
Member

@wsobel wsobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wsobel wsobel merged commit 298c4e2 into main Jan 11, 2024
@wsobel wsobel deleted the sink_boost_log_linker_issue branch January 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants