Skip to content

⬆️🔒️ Lock file maintenance#203

Merged
renovate[bot] merged 7 commits into
mainfrom
renovate/lock-file-maintenance
Oct 8, 2025
Merged

⬆️🔒️ Lock file maintenance#203
renovate[bot] merged 7 commits into
mainfrom
renovate/lock-file-maintenance

Conversation

@renovate

@renovate renovate Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Note

Mend has cancelled the proposed renaming of the Renovate GitHub app being renamed to mend[bot].

This notice will be removed on 2025-10-07.


This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Sep 22, 2025
@renovate renovate Bot enabled auto-merge (squash) September 22, 2025 02:02
@renovate renovate Bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from a36dee3 to 1d379c7 Compare September 24, 2025 01:08
@denialhaag

Copy link
Copy Markdown
Member

Looks like this has to wait until a new version of qsharp is released.

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate Bot force-pushed the renovate/lock-file-maintenance branch from fbad609 to 2de5002 Compare October 3, 2025 14:46
@renovate

renovate Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@denialhaag denialhaag self-assigned this Oct 6, 2025
@denialhaag denialhaag force-pushed the renovate/lock-file-maintenance branch from 439dc50 to d2d5b51 Compare October 6, 2025 21:36
@denialhaag denialhaag linked an issue Oct 7, 2025 that may be closed by this pull request
@denialhaag

denialhaag commented Oct 7, 2025

Copy link
Copy Markdown
Member

@burgholzer, to be able to move on here, we might need to require qiskit<2.0.0 because qsharp does so: https://github.com/microsoft/qdk/blob/e39d888e830c2f24119638059ba2033053c130aa/source/qdk_package/pyproject.toml#L22

@burgholzer

Copy link
Copy Markdown
Member

@burgholzer, to be able to move on here, we might need to require qiskit<2.0.0 because qsharp does so: https://github.com/microsoft/qdk/blob/e39d888e830c2f24119638059ba2033053c130aa/source/qdk_package/pyproject.toml#L22

Previously, this worked just fine with Qiskit 2.1. Even though qsharp did not indicate compatibility. Is there any change in 2.2 that breaks this explicitly?

@denialhaag

Copy link
Copy Markdown
Member

It should be this change that removed **kwargs from Target.__new__(): https://github.com/Qiskit/qiskit/pull/14921/files#diff-00276708f86c726ae04a2c670e74177eaad6aad971e017951bb5792501d13bf5L202-L203

@burgholzer

Copy link
Copy Markdown
Member

It should be this change that removed **kwargs from Target.__new__(): https://github.com/Qiskit/qiskit/pull/14921/files#diff-00276708f86c726ae04a2c670e74177eaad6aad971e017951bb5792501d13bf5L202-L203

Hm. The interesting thing to me is that it's the minimum sessions that are failing here, not the regular test session. Something is slightly odd about that.
Could we just not raise the lower bound for the pytket_qiskit dependency and see if that works?

@denialhaag

Copy link
Copy Markdown
Member

The minimum pytket_qiskit version has already been raised to the latest available version. This indirectly raises the minimum Qiskit version to 2.2. The problem is then that qsharp is incompatible with Qiskit 2.2.

@burgholzer

Copy link
Copy Markdown
Member

The minimum pytket_qiskit version has already been raised to the latest available version. This indirectly raises the minimum Qiskit version to 2.2. The problem is then that qsharp is incompatible with Qiskit 2.2.

I was actually trying to argue that we should lower the lower bound on the pytket_tket dependency as we should permit older versions as well.
However, I am not quite sure this would actually solve things.
To be fair, this might be considered a breaking change in Qiskit 2.2 and it might be worth raising an issue about this. Strictly speaking it violates the stability policy of Qiskit.

@denialhaag

denialhaag commented Oct 8, 2025

Copy link
Copy Markdown
Member

Sorry, I misunderstood you then! You are right that the minimum versions are too high here. I'll try to find better minimums later!

That said, I think we will just be shifting the errors from the minimums session to the tests session.

I will also raise a Qiskit issue later. 👍

@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@renovate renovate Bot merged commit cf543f0 into main Oct 8, 2025
16 checks passed
@renovate renovate Bot deleted the renovate/lock-file-maintenance branch October 8, 2025 22:43
@denialhaag

Copy link
Copy Markdown
Member

Sorry... I oversaw that the PR was set to auto-merge...

I set more reasonable minimum versions now. I did not immediately find a way to extend support to Qiskit 1.3 because the PhaseOracle needs tweedledum to be installed, which is so outdated that it cannot be installed via a uv because of an illegal pyproject.toml.

For now, we are requiring qiskit<2.2 because of the qsharp issue described above. I have created Qiskit/qiskit#15142.

@burgholzer, please let me know if something doesn't look good to you. I can open another PR fix that!

Comment thread pyproject.toml
"pytket-qiskit>=0.71.0",
"pytket>=1.29.0",
"pytket-qiskit>=0.67.0",
"qiskit-ibm-runtime>=0.38.0,<0.42.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the only thing that does not really look good to me as we upper cap the dependency again.
But probably this is unavoidable for now. So let's just go with it for now.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the requirement qiskit-ibm-runtime<0.42.0 unfortunately goes hand in hand with qiskit<2.2. Let's see what the Qiskit devs say. 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📌 Unpin qiskit-ibm-runtime

2 participants