Provider serves DNS proxy on Openvpn's virtual IP - #1281
Merged
Conversation
Waldz
commented
Aug 27, 2019
Waldz
commented
Member
Waldz
force-pushed
the
feature/dns-proxy-proc
branch
from
August 27, 2019 12:26
cc624a7 to
f3c17fd
Compare
soffokl
approved these changes
Aug 28, 2019
Waldz
force-pushed
the
feature/dns-proxy-proc
branch
from
August 29, 2019 10:09
f3c17fd to
e5f58d2
Compare
vkuznecovas
approved these changes
Aug 29, 2019
iberflow
approved these changes
Aug 29, 2019
soffokl
approved these changes
Aug 29, 2019
tadaskay
reviewed
Aug 29, 2019
| m.natPinger.BindServicePort(openvpn_service.ServiceType, m.vpnServerPort) | ||
|
|
||
| log.Info(logPrefix, "starting openvpn server on port: ", m.vpnServerPort) | ||
| log.Info(logPrefix, "Starting openvpn server on port: ", m.vpnServerPort) |
Contributor
There was a problem hiding this comment.
Case should be consistent, i.e. lowercase
Member
Author
There was a problem hiding this comment.
So logs most places we do with log.Info("Uppercase ..").
Maybe You're mixing with errors.New("lowercase ..") which is Golang convention.
Contributor
There was a problem hiding this comment.
No @Waldz, I'm talking about the logging messages. They are not consistent throughout the application, thus no, in most places, we don't do capitalization of the log messages. Quite often, the error is being logged as-is, resulting in a lowercase message as well. Perhaps it's a good addition for our devbook if we can agree on the choice?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.