Enable cookies in UI reverse proxy - #1311
Merged
Merged
Conversation
iberflow
requested review from
Waldz,
soffokl,
tadaskay,
vkuznecovas and
zolia
September 23, 2019 10:03
tadaskay
approved these changes
Sep 23, 2019
soffokl
approved these changes
Sep 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables CORS cookies. Problem was that ModifyResponse was setting additional headers so the CORS origin header had multiple entries. Another problem was that Gin CORS middleware was using a wildcard for the Access-Control-Allow-Origin and that doesn't work for CORS calls with cookies, it has to be set explicit.
This wasn't an issue before since UI is running on the exact same host:port as the reverse proxy.