Report node type and country in proposal events - #1318
Merged
Conversation
Waldz
approved these changes
Oct 2, 2019
zolia
approved these changes
Oct 2, 2019
anjmao
reviewed
Oct 2, 2019
|
|
||
| func proposalEventToMetricsEvent(context market.ServiceProposal, info appInfo) *metrics.Event { | ||
| location := context.ServiceDefinition.GetLocation() | ||
| return &metrics.Event{ |
Contributor
There was a problem hiding this comment.
Just a question. Have you guys thought about using prometheus instrumentations for metrics?
Member
Author
There was a problem hiding this comment.
It's Prometheus at the end of the chain. On the node level, we need some abstract push-based metrics, which can be compatible with any solution.
soffokl
force-pushed
the
feature/report-proposal-type
branch
from
October 2, 2019 09:11
3776bb1 to
f1e8c49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.