Automatic top up after registration - #1358
Merged
Merged
Conversation
soffokl
reviewed
Oct 17, 2019
vkuznecovas
force-pushed
the
top-up-after-registration
branch
2 times, most recently
from
October 17, 2019 07:06
76afa38 to
5e547c3
Compare
anjmao
reviewed
Oct 17, 2019
vkuznecovas
force-pushed
the
top-up-after-registration
branch
3 times, most recently
from
October 17, 2019 12:47
ba02836 to
c3a0cbc
Compare
tadaskay
approved these changes
Oct 17, 2019
zolia
approved these changes
Oct 18, 2019
| if err != nil { | ||
| log.Warnf("could not top up newly registered identity channel %v. Will retry", err) | ||
| if i+1 == tu.retryAttempts { | ||
| log.Errorf("top up failed after multiple attempts, aborting", err) |
Contributor
There was a problem hiding this comment.
We probably should monitor such metric. This would probably mean that transactor is either:
- very loaded
- unreachable
- down
- malfunctioning
Report spikes from such events would signal us to take actions immediately.
We could report such metric to quality oracle. We should probably have a ticket for this and for similar cases.
Contributor
Author
There was a problem hiding this comment.
This should probably go under transactor monitoring itself.
We'll now top up the channel after a succesful registration
vkuznecovas
force-pushed
the
top-up-after-registration
branch
from
October 18, 2019 07:19
c3a0cbc to
6f96420
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll now top up the channel after a succesful registration
Closes #1294