Update to latest wireguard - #1410
Merged
Merged
Conversation
tadaskay
requested review from
soffokl,
tadovas,
vkuznecovas and
zolia
as code owners
November 14, 2019 16:36
soffokl
reviewed
Nov 15, 2019
| return nil | ||
| } | ||
| err := goGet("github.com/nomad-software/vend") | ||
| err := goGet("github.com/mysteriumnetwork/vend") |
Member
There was a problem hiding this comment.
We need a patched vendor tool to vendor our patched wireguard. It feels like we doing something wrong. :D
Contributor
Author
There was a problem hiding this comment.
This is only because gomobile does not support gomodules yet
Member
There was a problem hiding this comment.
Let's patch gomobile to support gomodules. 💃
Contributor
Author
There was a problem hiding this comment.
We could contribute but that will take a while.
| "github.com/mysteriumnetwork/node/core/connection" | ||
| "github.com/mysteriumnetwork/node/services/wireguard" | ||
| "github.com/mysteriumnetwork/node/services/wireguard/key" | ||
| "github.com/mysteriumnetwork/wireguard-go/device" |
Member
There was a problem hiding this comment.
From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing.
Contributor
Author
There was a problem hiding this comment.
The goal is to integrate sooner into upstream. It is only logical that we keep original packages.
soffokl
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased our fork on latest https://github.com/WireGuard/wireguard-go head and reworked our patches.
Branch name is sync-fork (not pushing to master for now to keep original patch commits)