Fix log file rolling & cleanup - #1467
Merged
Merged
Conversation
In previous go versions, this used to utilize cgo, but not anymore.
Fix log filename not having any name (only .log)
tadaskay
requested review from
Waldz,
anjmao,
iberflow,
soffokl,
vkuznecovas and
zolia
December 19, 2019 12:30
iberflow
approved these changes
Dec 19, 2019
anjmao
reviewed
Dec 19, 2019
Logging to data dir previously had unintended side effects during the log collection. Using a dedicated dir from now on.
It will leave no more files than configured with MaxRemain. Eventually, there will be MaxRemain*2 files left in log dir, because rolling writer does not cleanup files from the previous startups, but I think it's good enough: subsequent startups of node will clean the old files again.
tadaskay
force-pushed
the
1460-remove-old-logs
branch
from
December 19, 2019 18:52
b4339a5 to
75929fb
Compare
anjmao
approved these changes
Dec 20, 2019
zolia
approved these changes
Dec 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1460
Fixes: #1416