Skip to content

Remove redundant storage + relevent code from exchange message tracker - #1601

Merged
vkuznecovas merged 1 commit into
masterfrom
remove-redundant-code
Jan 31, 2020
Merged

Remove redundant storage + relevent code from exchange message tracker#1601
vkuznecovas merged 1 commit into
masterfrom
remove-redundant-code

Conversation

@vkuznecovas

Copy link
Copy Markdown
Contributor

No description provided.

@vkuznecovas
vkuznecovas force-pushed the remove-redundant-code branch from 4d5f998 to 591c123 Compare January 30, 2020 14:30
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1601 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
- Coverage   47.79%   47.79%   -0.01%     
==========================================
  Files         289      289              
  Lines       11550    11519      -31     
==========================================
- Hits         5520     5505      -15     
+ Misses       5635     5619      -16     
  Partials      395      395
Impacted Files Coverage Δ
session/pingpong/factory.go 0% <ø> (ø) ⬆️
session/pingpong/invoice_storage.go 93.47% <ø> (+18.85%) ⬆️
session/pingpong/exchange_message_tracker.go 90.21% <100%> (+1.1%) ⬆️
communication/nats/dialog/dialog_waiter.go 85.91% <0%> (-2.82%) ⬇️
core/promise/methods/noop/dialog_mock.go 71.87% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9251369...591c123. Read the comment docs.

@vkuznecovas
vkuznecovas merged commit bf86047 into master Jan 31, 2020
@vkuznecovas
vkuznecovas deleted the remove-redundant-code branch January 31, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants