Skip to content

Handle accountant errors - #1618

Merged
vkuznecovas merged 2 commits into
masterfrom
handle-accountant-errors
Feb 4, 2020
Merged

Handle accountant errors#1618
vkuznecovas merged 2 commits into
masterfrom
handle-accountant-errors

Conversation

@vkuznecovas

Copy link
Copy Markdown
Contributor

Until now, all errors from accountant were treated equally. They are now classified and acted upon accordingly.

Comment thread session/pingpong/invoice_tracker.go Outdated
@vkuznecovas
vkuznecovas force-pushed the handle-accountant-errors branch from 0add0df to 70d4650 Compare February 4, 2020 08:11
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1618 into master will increase coverage by 0.18%.
The diff coverage is 59.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   48.43%   48.62%   +0.18%     
==========================================
  Files         291      291              
  Lines       11648    11693      +45     
==========================================
+ Hits         5642     5686      +44     
+ Misses       5594     5591       -3     
- Partials      412      416       +4
Impacted Files Coverage Δ
session/pingpong/factory.go 0% <0%> (ø) ⬆️
session/pingpong/accountant_promise_settler.go 50.24% <0%> (-2.31%) ⬇️
session/pingpong/invoice_tracker.go 64.75% <65.78%> (+9.28%) ⬆️
session/pingpong/accountant_caller.go 72.91% <73.07%> (-4.87%) ⬇️
services/wireguard/connection/connection.go 64.74% <0%> (-2.16%) ⬇️
core/connection/manager.go 82.74% <0%> (-0.64%) ⬇️
tequilapi/sse/sse.go 74.44% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2406773...70d4650. Read the comment docs.

Until now, all errors from accountant were treated equally. They are now classified and acted upon accordingly.
@vkuznecovas
vkuznecovas force-pushed the handle-accountant-errors branch from 70d4650 to cdbbac2 Compare February 4, 2020 09:41
@vkuznecovas
vkuznecovas requested a review from soffokl February 4, 2020 09:42
@vkuznecovas
vkuznecovas merged commit 57851b9 into master Feb 4, 2020
@vkuznecovas
vkuznecovas deleted the handle-accountant-errors branch February 4, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants