Handle accountant errors - #1618
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
February 3, 2020 13:31
anjmao
approved these changes
Feb 3, 2020
soffokl
reviewed
Feb 4, 2020
vkuznecovas
force-pushed
the
handle-accountant-errors
branch
from
February 4, 2020 08:11
0add0df to
70d4650
Compare
Codecov Report
@@ Coverage Diff @@
## master #1618 +/- ##
==========================================
+ Coverage 48.43% 48.62% +0.18%
==========================================
Files 291 291
Lines 11648 11693 +45
==========================================
+ Hits 5642 5686 +44
+ Misses 5594 5591 -3
- Partials 412 416 +4
Continue to review full report at Codecov.
|
Until now, all errors from accountant were treated equally. They are now classified and acted upon accordingly.
vkuznecovas
force-pushed
the
handle-accountant-errors
branch
from
February 4, 2020 09:41
70d4650 to
cdbbac2
Compare
soffokl
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, all errors from accountant were treated equally. They are now classified and acted upon accordingly.