Sync consumer balance every time on startup - #1860
Merged
Merged
Conversation
Waldz
requested review from
anjmao,
chompomonim,
soffokl,
tadaskay,
vkuznecovas and
zolia
March 9, 2020 13:54
Waldz
force-pushed
the
bugfix/stale-balance-disconnects-session
branch
from
March 9, 2020 13:54
4b9db97 to
788d33c
Compare
vkuznecovas
reviewed
Mar 9, 2020
|
|
||
| const grandTotalKey = "consumer_grand_total" | ||
|
|
||
| func (ip *InvoicePayer) getGrandTotalPromised() (uint64, error) { |
Contributor
There was a problem hiding this comment.
don't remove this func, the force-sync is temporary and we will need to operate on balances we have in state
Member
Author
There was a problem hiding this comment.
So we have ip.deps.ConsumerTotalsStorage.Get() for that and I created recoverGrandTotalPromised() for syncing it if needed
Waldz
force-pushed
the
bugfix/stale-balance-disconnects-session
branch
from
March 9, 2020 15:30
788d33c to
bfa5e30
Compare
zolia
approved these changes
Mar 10, 2020
anjmao
approved these changes
Mar 10, 2020
zolia
added a commit
that referenced
this pull request
Mar 10, 2020
…isconnects-session Sync consumer balance every time on startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1851