Conversation
tadaskay
requested review from
Waldz,
anjmao,
soffokl,
vkuznecovas and
zolia
as code owners
March 28, 2020 10:59
Waldz
approved these changes
Mar 28, 2020
This caused old session being left intact when disconnected. When client attempts to connect to another provider, he is shown an old session/proposal (via SSE).
tadaskay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
+ Coverage 47.48% 47.98% +0.49%
==========================================
Files 286 287 +1
Lines 12108 12617 +509
==========================================
+ Hits 5750 6054 +304
- Misses 5878 5999 +121
- Partials 480 564 +84
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.