Payment e2e test - #2013
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 6, 2020 13:01
vkuznecovas
force-pushed
the
payment-e2e-test
branch
from
April 6, 2020 13:02
823ac6e to
8312217
Compare
zolia
approved these changes
Apr 6, 2020
| fees, err := tequilapiProvider.GetTransactorFees() | ||
| assert.NoError(t, err) | ||
|
|
||
| accountantFee := math.Round(0.04 * float64(providerStatus.EarningsTotal)) |
| expected := initialBalance + providerStatus.EarningsTotal - fees.Settlement - accountantFeeUint | ||
|
|
||
| // To avoid running into rounding errors, assume a delta of 2 micromyst is OK | ||
| assert.InDelta(t, expected, providerStatus.Balance, 2) |
Codecov Report
@@ Coverage Diff @@
## master #2013 +/- ##
==========================================
- Coverage 48.02% 47.94% -0.09%
==========================================
Files 290 290
Lines 13024 13026 +2
==========================================
- Hits 6255 6245 -10
- Misses 6189 6199 +10
- Partials 580 582 +2
Continue to review full report at Codecov.
|
soffokl
approved these changes
Apr 7, 2020
Verifies provider earnings.
vkuznecovas
force-pushed
the
payment-e2e-test
branch
from
April 7, 2020 06:29
8312217 to
b3814f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added payment + settlement tests.
Fixes #1330