Pass context for nat pinger cancellation - #2023
Merged
Merged
Conversation
anjmao
requested review from
Waldz,
soffokl,
tadaskay,
vkuznecovas and
zolia
as code owners
April 7, 2020 08:20
soffokl
approved these changes
Apr 7, 2020
vkuznecovas
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose context up from the connection manager so it can set global deadline for connecting and use the same for cancellation when user clicks cancel.
Also small improvement for nat pinger on provider side to wait all available pings instead of just n required.
Fixes #2018