Fixes NAT e2e - #2070
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 15, 2020 23:08
vkuznecovas
force-pushed
the
fix-e2e-nat
branch
from
April 15, 2020 23:09
d587685 to
804815b
Compare
soffokl
approved these changes
Apr 16, 2020
anjmao
approved these changes
Apr 16, 2020
zolia
approved these changes
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will fall back to previous balance in case there's an issue with force refresh.
It seems that the reconnect does not work reliably for ethereum client though as this was caused by the following chain:
disconnect event emitted -> disconnect event causes eth client reconnect -> client fails to reconnect(a log is printed) -> tests call force balance update from consumer through tequila -> a 0 value is returned on force balance refresh due to the failed eth client request.