Faster e2e implementation - #2087
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 17, 2020 11:55
vkuznecovas
force-pushed
the
fast-e2e
branch
7 times, most recently
from
April 17, 2020 13:30
7345ab0 to
37053ed
Compare
anjmao
approved these changes
Apr 17, 2020
zolia
approved these changes
Apr 18, 2020
soffokl
approved these changes
Apr 20, 2020
anjmao
reviewed
Apr 20, 2020
vkuznecovas
force-pushed
the
fast-e2e
branch
2 times, most recently
from
April 20, 2020 07:50
fa9384d to
dc95a75
Compare
Waldz
approved these changes
Apr 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 47.68% 47.41% -0.27%
==========================================
Files 290 289 -1
Lines 13359 13320 -39
==========================================
- Hits 6370 6316 -54
- Misses 6380 6401 +21
+ Partials 609 603 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New:
mage teste2ebasic 43.23s user 18.09s system 21% cpu 4:45.21 total
Old:
mage teste2ebasic 29.06s user 12.90s system 8% cpu 8:42.82 total
As a bonus, the mac now stays cool to the touch when running e2e. The savings will be smaller on linux, but I expect them to still be noticeable.