Do not allow to overwrite accountant promise to lower value - #2103
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 22, 2020 15:28
anjmao
approved these changes
Apr 22, 2020
soffokl
approved these changes
Apr 23, 2020
vkuznecovas
force-pushed
the
prevent-promise-overwrite
branch
from
April 23, 2020 06:19
a7013a2 to
23fc664
Compare
tadaskay
approved these changes
Apr 23, 2020
vkuznecovas
force-pushed
the
prevent-promise-overwrite
branch
from
April 23, 2020 06:31
23fc664 to
cb6df4b
Compare
vkuznecovas
force-pushed
the
prevent-promise-overwrite
branch
from
April 23, 2020 06:36
cb6df4b to
c98331e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accountant promise has an ever increasing value. Storage now validates this before overwriting.