Even faster e2e - #2111
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 24, 2020 09:49
vkuznecovas
force-pushed
the
faster-e2e
branch
3 times, most recently
from
April 24, 2020 11:17
8f959c3 to
355c7cd
Compare
anjmao
suggested changes
Apr 24, 2020
anjmao
left a comment
anjmao
left a comment
Contributor
There was a problem hiding this comment.
Now you can sleep well 😆
Requesting a change as it looks there is a bug in start stop. Please check. Everything looks good.
anjmao
self-requested a review
April 24, 2020 11:53
anjmao
approved these changes
Apr 24, 2020
Previously, each session would try and handle their own accountant promises. This caused a bunch of race conditions. Now, the sessions each delegate the promise related work to accountant promise handler.
Waldz
reviewed
Apr 24, 2020
| openvpn,noop,wireguard | ||
|
|
||
| myst-consumer: | ||
| myst-consumer-noop: |
Member
There was a problem hiding this comment.
Lets have one consumer and create sessions from it. Doing consequent connects/disconnect showed bunch of bugs for us.
How to keep testing that?
Member
There was a problem hiding this comment.
maybe additional connect after 1st session?
Member
There was a problem hiding this comment.
Actually connects should happen in same container, to catch race bugs for us.
But we can run those connect tests in parallel
Contributor
Author
There was a problem hiding this comment.
I leave this as an exercise to the reader. Need a break from e2e for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2e now starts multiple consumers, these then connect to the provider simultaneously. This mimics the real world scenario more closely.
Had to refactor accountant promise handling flow, as this caused insane races. To fix it, moved all the accountant promise logic to a new component:
accountant_promise_handler.go. It will handle the promises sequentially and avoid race conditions.Time savings:
After
mage teste2ebasic 32.50s user 17.48s system 24% cpu 3:20.12 totalBefore
mage teste2ebasic 45.29s user 18.08s system 21% cpu 4:58.23 total