Alleviate the connection race pains - #2148
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
April 29, 2020 12:22
Waldz
approved these changes
Apr 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
=======================================
Coverage 47.95% 47.95%
=======================================
Files 290 290
Lines 13398 13398
=======================================
Hits 6425 6425
+ Misses 6355 6352 -3
- Partials 618 621 +3
Continue to review full report at Codecov.
|
vkuznecovas
force-pushed
the
stabler-e2e
branch
from
April 29, 2020 12:54
bfd660d to
42c4ab8
Compare
soffokl
reviewed
Apr 30, 2020
anjmao
approved these changes
Apr 30, 2020
With the connection statuses being reported rather quickly races might happen. Eventually will prevent these.
vkuznecovas
force-pushed
the
stabler-e2e
branch
from
April 30, 2020 06:29
42c4ab8 to
fb90e40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the connection statuses being reported rather quickly races might happen.
Eventually will prevent these.