Fix leaking goroutines in NAT pinger - #2160
Merged
Merged
Conversation
soffokl
requested review from
Waldz,
anjmao,
tadaskay,
vkuznecovas and
zolia
as code owners
May 4, 2020 05:48
zolia
reviewed
May 4, 2020
|
|
||
| // waitMsg waits until conn receives given message or timeouts. | ||
| func waitMsg(ctx context.Context, conn *net.UDPConn, msg string) error { | ||
| ok := make(chan struct{}) |
Contributor
There was a problem hiding this comment.
How does this help to fix a leak?
Member
Author
There was a problem hiding this comment.
It does not block on writing to channel when no one reads from the channel.
anjmao
approved these changes
May 4, 2020
vkuznecovas
approved these changes
May 4, 2020
soffokl
force-pushed
the
bugfix/pinger-goroutine-leak
branch
from
May 4, 2020 09:00
b1489d9 to
2a96c61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2159