Remove redundant check for consumer registration - #2171
Merged
Conversation
vkuznecovas
requested review from
Waldz,
anjmao,
soffokl,
tadaskay and
zolia
as code owners
May 5, 2020 09:13
soffokl
approved these changes
May 5, 2020
anjmao
approved these changes
May 5, 2020
Provider will no longer check if consumer is registered before accepting session. This is redudant because Hermes will do the check and reject the promise if needed. It is also a prerequisite for fast registration. Updates #2027
vkuznecovas
force-pushed
the
remove-registration-check
branch
from
May 5, 2020 10:25
8694b4b to
a9b5460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider will no longer check if consumer is registered before accepting session.
This is redudant because Hermes will do the check and reject the promise if needed.
It is also a prerequisite for fast registration.
Updates #2027