Skip to content

Use mysterium service for IP detection on mobile - #2970

Merged
soffokl merged 1 commit into
masterfrom
fix-mobile-unstable-connect
Jan 5, 2021
Merged

Use mysterium service for IP detection on mobile#2970
soffokl merged 1 commit into
masterfrom
fix-mobile-unstable-connect

Conversation

@soffokl

@soffokl soffokl commented Jan 5, 2021

Copy link
Copy Markdown
Member

Do not rely on third-party service and use mysterium services for IP detection

2021-01-05 11:08:06.817 31710-31710/network.mysterium.vpn E/ProposalsFragment: Failed to connect
    network.mysterium.service.core.ConnectUnknownException: could not create p2p channel during connect: p2p dialer failed: could not prepare ports: could not get public IP: Get https://api.ipify.org/?format=json: x509: certificate is valid for *.duracloud.org, duracloud.org, not api.ipify.org
        at network.mysterium.service.core.NodeRepository$connect$2.invokeSuspend(NodeRepository.kt:166)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:594)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.access$runSafely(CoroutineScheduler.kt:60)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:740)
2021-01-05 11:08:07

Closes #2964

@soffokl soffokl self-assigned this Jan 5, 2021
@soffokl
soffokl requested a review from zolia as a code owner January 5, 2021 05:10
@soffokl soffokl changed the title Use mysterium service for IP detection Use mysterium service for IP detection on mobile Jan 5, 2021
FeedbackURL: "https://feedback.mysterium.network",
QualityOracleURL: "https://testnet2-quality.mysterium.network/api/v1",
IPDetectorURL: "https://api.ipify.org/?format=json",
IPDetectorURL: "https://testnet2-location.mysterium.network/api/v1/location",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop ipify in all places i guess

@soffokl
soffokl force-pushed the fix-mobile-unstable-connect branch 3 times, most recently from 9c242d9 to 27e9f01 Compare January 5, 2021 08:28
@soffokl
soffokl force-pushed the fix-mobile-unstable-connect branch from 27e9f01 to f8c0347 Compare January 5, 2021 08:56
@soffokl
soffokl merged commit 69532de into master Jan 5, 2021
@soffokl
soffokl deleted the fix-mobile-unstable-connect branch January 5, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android app is connecting only from second/third time

4 participants