Migrate to the new metrics with support country and version everywhere - #3025
Merged
Conversation
soffokl
requested review from
Waldz,
iberflow,
mdomasevicius,
tadaskay,
tomasmik and
vkuznecovas
January 20, 2021 06:10
soffokl
force-pushed
the
merge-metrics
branch
2 times, most recently
from
January 20, 2021 06:12
7ab7804 to
f1327ab
Compare
tomasmik
approved these changes
Jan 20, 2021
|
|
||
| var errEventNotImplemented = errors.New("event not implemented") | ||
|
|
||
| type locationProvider interface { |
Contributor
There was a problem hiding this comment.
The Sender (sender.go) is sort of also sprinkled with this same location data. It listens for location event and caches that information. If we no longer care about it from the sender himself, I guess we can remove it from there.
Or we can reuse it from there removing this. (though I guess option 1 is easier)
tomasmik
approved these changes
Jan 20, 2021
vkuznecovas
approved these changes
Jan 20, 2021
soffokl
force-pushed
the
merge-metrics
branch
from
January 21, 2021 05:53
ead4a65 to
57431d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for #2776