Split SC address per chain - #3027
Merged
Merged
Conversation
vkuznecovas
requested review from
Waldz,
soffokl,
tadaskay and
zolia
as code owners
January 20, 2021 09:22
vkuznecovas
force-pushed
the
split-sc-address-per-chain
branch
2 times, most recently
from
January 20, 2021 10:45
9d97ae0 to
02f73e1
Compare
tomasmik
reviewed
Jan 20, 2021
|
|
||
| func getChainIDFlag(chainIndex int64) cli.Int64Flag { | ||
| defaultAddress := metadata.DefaultNetwork.Chain1.ChainID | ||
| if chainIndex == 2 { |
Contributor
There was a problem hiding this comment.
If DefaultNetwork has map of chains instead of each chain as a seperate var, we would not need this if
Though it would be worse to look up outside of here.
vkuznecovas
force-pushed
the
split-sc-address-per-chain
branch
4 times, most recently
from
January 20, 2021 14:55
71e0efd to
3683b80
Compare
soffokl
approved these changes
Jan 21, 2021
tomasmik
approved these changes
Jan 21, 2021
vkuznecovas
force-pushed
the
split-sc-address-per-chain
branch
from
January 21, 2021 09:28
b204c84 to
682e056
Compare
vkuznecovas
force-pushed
the
split-sc-address-per-chain
branch
from
January 21, 2021 09:31
682e056 to
63fe4fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2988