Set correct MTU size for windows - #3157
Merged
Merged
Conversation
soffokl
requested review from
chompomonim,
mdomasevicius,
tadaskay,
tomasmik and
vkuznecovas
March 4, 2021 03:49
soffokl
commented
Mar 4, 2021
| wintun, err := tun.CreateTUN(interfaceName, 0) | ||
| wintun, err := tun.CreateTUN(interfaceName, device.DefaultMTU) | ||
| if err != nil { | ||
| return nil, interfaceName, fmt.Errorf("could not create Wintun tunnel: %w", err) |
Member
Author
There was a problem hiding this comment.
We are passing interfaceName and then returing that interfaceName, wtf?
Contributor
There was a problem hiding this comment.
If you look at the darwin implementation of this, you will notice that the requested interface name and resulting name might be different, e.g.: utun -> utun6
tadaskay
approved these changes
Mar 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
- Coverage 44.54% 44.09% -0.45%
==========================================
Files 305 305
Lines 13420 13493 +73
==========================================
- Hits 5978 5950 -28
- Misses 6737 6842 +105
+ Partials 705 701 -4
Continue to review full report at Codecov.
|
tomasmik
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3138