Offchain identity registration and balance handling - #3253
Merged
Conversation
tomasmik
force-pushed
the
offchain-identity
branch
3 times, most recently
from
March 29, 2021 14:00
c703e42 to
6be1578
Compare
tomasmik
marked this pull request as ready for review
March 29, 2021 14:03
tomasmik
force-pushed
the
offchain-identity
branch
3 times, most recently
from
March 29, 2021 14:19
d3ed2c3 to
9e3050b
Compare
tomasmik
force-pushed
the
offchain-identity
branch
from
March 29, 2021 15:22
9e3050b to
b969665
Compare
soffokl
approved these changes
Mar 30, 2021
vkuznecovas
approved these changes
Mar 31, 2021
mdomasevicius
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offchain identities are now supported in node.
registeredIf at any point we fail to contact hermes we continue assuming that the identity is not offchain. This eliminates our service from not working if hermes is unreachable or introduces some breaking changes in the check endpoint.
This does put additional strain on hermes, but I cannot think of a better way to do this.