Fix double call of session destroy. - #3352
Merged
Merged
Conversation
The scenario goes like this: * `destroy` func is included in `sessionCleanup` and returned to the session manager * If `(m *Manager) Stop() ..` is called first then the `SessionManager` still holds the function * If `SessionManager` starts to cleanup session it calls the destroy func which was already called And we get a close of a closed channel bringing the node down. To fix this we now: * Check if the session hasn't been cleaned up, if so function call does nothing. * Wrap `close` in sync.Once just for good measure.
tomasmik
requested review from
Waldz,
alvatar,
eugenegoncharuk,
mdomasevicius,
soffokl,
tadaskay and
vkuznecovas
May 4, 2021 07:52
vkuznecovas
approved these changes
May 4, 2021
mdomasevicius
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario goes like this:
destroyfunc is included insessionCleanupand returned to the session manager(m *Manager) Stop() ..is called first then theSessionManagerstill holds the functionSessionManagerstarts to cleanup session it calls the destroy func which was already calledAnd we get a close of a closed channel bringing the node down.
To fix this we now:
closein sync.Once just for good measure.Closes: #3351
Closes: #3310