Set stop timeout for service to finish cleanup - #3438
Merged
Conversation
On some slow machines 10 seconds is not enough to finish cleanup process. This leads to issues when consumer can keep using connection even after myst process exited. This sets default stop timeout to default value 90 seconds.
tomasmik
approved these changes
May 31, 2021
vkuznecovas
approved these changes
May 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some slow machines, 10 seconds is not enough to finish the cleanup process.
This leads to issues when consumers can keep using connections even after myst process exited.
This sets default stop timeout to the default value of 90 seconds.