Enable cache eviction & simplify logic - #3473
Merged
Merged
Conversation
mdomasevicius
requested review from
Waldz,
soffokl,
tadaskay and
zolia
as code owners
June 14, 2021 14:09
vkuznecovas
approved these changes
Jun 14, 2021
mdomasevicius
commented
Jun 14, 2021
| if err != nil { | ||
| return nil, err | ||
| } | ||
| m.addToCache(apiProposals) |
Collaborator
Author
There was a problem hiding this comment.
In reality this is just a API call throttling. In the spirit of previous implementation I leave it multi-thread non-safe :)
tomasmik
approved these changes
Jun 14, 2021
mdomasevicius
force-pushed
the
features/proposal-caching
branch
from
June 15, 2021 06:07
2372ada to
5dd451b
Compare
Signed-off-by: Mantas Domaševičius <mantas@mysterium.network>
mdomasevicius
force-pushed
the
features/proposal-caching
branch
from
June 15, 2021 06:25
5dd451b to
41285ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 43.27% 43.31% +0.03%
==========================================
Files 313 313
Lines 13818 13822 +4
==========================================
+ Hits 5980 5987 +7
- Misses 7112 7115 +3
+ Partials 726 720 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.