Check response status when calling MMN - #4007
Merged
Merged
Conversation
tomasmik
commented
Sep 28, 2021
Contributor
- Close body
- Check response code
tomasmik
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay,
vkuznecovas and
zolia
as code owners
September 28, 2021 14:30
tomasmik
force-pushed
the
check-mmn-resp
branch
from
September 28, 2021 14:30
9150c03 to
8d5aa46
Compare
Snawoot
approved these changes
Sep 28, 2021
tomasmik
force-pushed
the
check-mmn-resp
branch
from
September 28, 2021 14:35
8d5aa46 to
359c948
Compare
Codecov Report
@@ Coverage Diff @@
## master #4007 +/- ##
==========================================
+ Coverage 43.35% 43.40% +0.04%
==========================================
Files 331 331
Lines 17422 17422
==========================================
+ Hits 7554 7562 +8
+ Misses 9110 9103 -7
+ Partials 758 757 -1
Continue to review full report at Codecov.
|
soffokl
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.