Handle registration status error for state subscribers - #4414
Merged
Conversation
If there are connection issues on initial load, apps will assume that user is unregistered forcing them to the topup screen. Now they can rely on state `Unknown` to be sure that something failed and should be retried.
soffokl
approved these changes
Dec 3, 2021
tadaskay
approved these changes
Dec 3, 2021
Snawoot
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are connection issues on initial load, apps will assume that user is unregistered forcing them to the topup/onboarding screen. Now they can rely on state
Unknownto be sure that something failed and should be retried.This change will need to handled in both android and desktop teams when they upgrade node.