Use forked library for log rotation - #4764
Merged
Merged
Conversation
Guillembonet
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay and
tomasmik
as code owners
February 10, 2022 09:06
Snawoot
suggested changes
Feb 10, 2022
Snawoot
left a comment
Snawoot
left a comment
Contributor
There was a problem hiding this comment.
Can you please give a link for diff between original and fork? Otherwise it's hard to understand what we actually approve.
Contributor
Author
@Snawoot check the PR or commit link above |
Contributor
|
@Guillembonet sorry, missed that. Let's wait until comments to PR to original repo will be addressed. |
Snawoot
approved these changes
Feb 10, 2022
Guillembonet
force-pushed
the
fix-log-rolling
branch
from
February 10, 2022 12:49
9657db7 to
cb5ff79
Compare
tomasmik
approved these changes
Feb 10, 2022
Signed-off-by: Guillem Bonet <guillem@mysterium.network>
Guillembonet
force-pushed
the
fix-log-rolling
branch
from
February 10, 2022 14:06
cb5ff79 to
d0b189d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forked the library to stop doing rename and delete operations with open files which failed on windows. Now it rotates correctly both in linux and windows, I also created a PR to merge it in the original repo so we can switch back eventually.
To review this PR I suggest looking at this commit.
Closes: #4630
Signed-off-by: Guillem Bonet guillem@mysterium.network