fix tests and return to using original log library - #4771
Merged
Conversation
Signed-off-by: Guillem Bonet <guillem@mysterium.network>
Guillembonet
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay and
tomasmik
as code owners
February 11, 2022 08:40
Snawoot
approved these changes
Feb 11, 2022
tomasmik
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test where file creation time is needed to be accurate seems to still fail sometimes in the pipeline. If this doesn't solve it I suggest we just do a simpler test with just one file. Also, we can now return to the original library for rollingwriter.
Closes: #4770
Signed-off-by: Guillem Bonet guillem@mysterium.network