Pass amounts as strings for the end-user - #4807
Merged
Merged
Conversation
tadaskay
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl and
tomasmik
as code owners
February 22, 2022 16:35
tadaskay
force-pushed
the
improvements/amounts-2
branch
from
February 22, 2022 17:07
f3e0055 to
79d74e0
Compare
tomasmik
approved these changes
Feb 23, 2022
This was referenced Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of - Pass identity balance as string #4697
It worked perfectly on the client side allowing to remove error prone logic to format huge MYSTs, but not completely, because some occurrences of money rounding/formatting/etc were still left. This PR fixes that.