Skip to content

Fix android build and build validation - #4814

Merged
soffokl merged 2 commits into
masterfrom
fix-andoid-build
Feb 25, 2022
Merged

Fix android build and build validation#4814
soffokl merged 2 commits into
masterfrom
fix-andoid-build

Conversation

@soffokl

@soffokl soffokl commented Feb 24, 2022

Copy link
Copy Markdown
Member

Closes: #4804
Closes: #4803

@soffokl soffokl added the bug label Feb 24, 2022
@soffokl soffokl self-assigned this Feb 24, 2022
@soffokl
soffokl force-pushed the fix-andoid-build branch 2 times, most recently from f6d2be8 to 3f9c27a Compare February 24, 2022 03:25
@codecov-commenter

codecov-commenter commented Feb 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4814 (0cbdcb7) into master (1f19e53) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4814      +/-   ##
==========================================
- Coverage   39.34%   39.25%   -0.09%     
==========================================
  Files         356      356              
  Lines       19148    19148              
==========================================
- Hits         7533     7517      -16     
- Misses      10890    10905      +15     
- Partials      725      726       +1     
Impacted Files Coverage Δ
tequilapi/endpoints/sse_handler.go 69.34% <0.00%> (-3.65%) ⬇️
nat/traversal/pinger.go 76.35% <0.00%> (-3.49%) ⬇️
requests/dialer_swarm.go 72.18% <0.00%> (-2.26%) ⬇️
session/pingpong/consumer_balance_tracker.go 56.63% <0.00%> (-0.72%) ⬇️
core/policy/oracle.go 91.89% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f19e53...0cbdcb7. Read the comment docs.

@soffokl
soffokl force-pushed the fix-andoid-build branch 4 times, most recently from fb8b04b to 5d6b3c2 Compare February 24, 2022 05:18
@soffokl soffokl changed the title Try to fix android build [ci full] Fix android build and build validation Feb 24, 2022
@soffokl
soffokl marked this pull request as ready for review February 24, 2022 05:34
@soffokl
soffokl merged commit 61bdd75 into master Feb 25, 2022
@soffokl
soffokl deleted the fix-andoid-build branch February 25, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mobile package build in the node Android build failed on latest node releases, but CI marked it as success

3 participants