Skip to content

#4459 Cli: latest withdrawal details - #4864

Merged
n10ty merged 2 commits into
masterfrom
4459-cli-last-witdrawal-info
Mar 14, 2022
Merged

#4459 Cli: latest withdrawal details#4864
n10ty merged 2 commits into
masterfrom
4459-cli-last-witdrawal-info

Conversation

@n10ty

@n10ty n10ty commented Mar 10, 2022

Copy link
Copy Markdown
Contributor

#4459 Add info about last transaction to cli

@n10ty
n10ty requested review from Guillembonet and tomasmik March 10, 2022 13:46
@n10ty
n10ty marked this pull request as ready for review March 10, 2022 13:47
Comment thread tequilapi/client/client.go Outdated
Comment thread cmd/commands/cli/command_identities.go
@n10ty
n10ty requested a review from tomasmik March 10, 2022 18:46

@tomasmik tomasmik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just squash those commits so that everything is verified

@Guillembonet Guillembonet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, as Tomas said, squash those commits :)

Signed-off-by: Andrey M <andrey@mysterium.network>
@n10ty
n10ty force-pushed the 4459-cli-last-witdrawal-info branch from 16fd7ef to a585959 Compare March 11, 2022 11:23
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4864 (70f4576) into master (e18b1ee) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4864      +/-   ##
==========================================
- Coverage   39.18%   39.15%   -0.04%     
==========================================
  Files         358      358              
  Lines       19169    19181      +12     
==========================================
- Hits         7512     7510       -2     
- Misses      10933    10949      +16     
+ Partials      724      722       -2     
Impacted Files Coverage Δ
session/pingpong/settlement_history_storage.go 51.28% <0.00%> (-1.35%) ⬇️
tequilapi/client/client.go 3.38% <0.00%> (-0.08%) ⬇️
p2p/channel.go 66.06% <0.00%> (-2.17%) ⬇️
core/policy/oracle.go 91.89% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18b1ee...70f4576. Read the comment docs.

@n10ty
n10ty merged commit 61f1e9b into master Mar 14, 2022
@n10ty
n10ty deleted the 4459-cli-last-witdrawal-info branch March 14, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants