Add uid into eventbus wrapper to mitigate unintended unsubscribe - #4927
Merged
Conversation
soffokl
requested review from
Snawoot,
mdomasevicius,
tadaskay and
tomasmik
as code owners
March 25, 2022 03:44
Codecov Report
@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
+ Coverage 39.18% 39.23% +0.04%
==========================================
Files 357 357
Lines 19187 19214 +27
==========================================
+ Hits 7519 7538 +19
- Misses 10946 10950 +4
- Partials 722 726 +4
Continue to review full report at Codecov.
|
Guillembonet
approved these changes
Mar 25, 2022
Guillembonet
left a comment
Contributor
There was a problem hiding this comment.
I think it should work! nice code!
tomasmik
approved these changes
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.