Skip to content

Add uid into eventbus wrapper to mitigate unintended unsubscribe - #4927

Merged
soffokl merged 2 commits into
masterfrom
fix-eventbus
Mar 25, 2022
Merged

Add uid into eventbus wrapper to mitigate unintended unsubscribe#4927
soffokl merged 2 commits into
masterfrom
fix-eventbus

Conversation

@soffokl

@soffokl soffokl commented Mar 25, 2022

Copy link
Copy Markdown
Member

No description provided.

@soffokl
soffokl requested a review from Waldz as a code owner March 25, 2022 03:44
@soffokl soffokl self-assigned this Mar 25, 2022
@soffokl
soffokl requested a review from Guillembonet March 25, 2022 04:18
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4927 (0d14fa6) into master (0d5e937) will increase coverage by 0.04%.
The diff coverage is 85.10%.

@@            Coverage Diff             @@
##           master    #4927      +/-   ##
==========================================
+ Coverage   39.18%   39.23%   +0.04%     
==========================================
  Files         357      357              
  Lines       19187    19214      +27     
==========================================
+ Hits         7519     7538      +19     
- Misses      10946    10950       +4     
- Partials      722      726       +4     
Impacted Files Coverage Δ
session/pingpong/invoice_payer.go 76.25% <60.00%> (-0.95%) ⬇️
session/pingpong/invoice_tracker.go 62.76% <66.66%> (ø)
eventbus/event_bus.go 84.61% <88.88%> (+22.11%) ⬆️
core/connection/manager.go 71.76% <100.00%> (+0.05%) ⬆️
core/policy/oracle.go 86.48% <0.00%> (-5.41%) ⬇️
requests/dialer_swarm.go 75.93% <0.00%> (-1.51%) ⬇️
nat/traversal/pinger.go 78.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5e937...0d14fa6. Read the comment docs.

@Guillembonet Guillembonet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work! nice code!

@soffokl
soffokl merged commit 8aba570 into master Mar 25, 2022
@soffokl
soffokl deleted the fix-eventbus branch March 25, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants