Referral api changes - #4941
Merged
Merged
Conversation
added 4 commits
March 28, 2022 12:30
…ralToken, ReferralTokenAvailable Signed-off-by: AndreyM <andrey@mysterium.network>
Do TokenRewardAmount request directly to Affiliator, not Transactor Signed-off-by: AndreyM <andrey@mysterium.network>
# Conflicts: # tequilapi/endpoints/assets/docs.go
Signed-off-by: AndreyM <andrey@mysterium.network>
n10ty
marked this pull request as ready for review
March 28, 2022 14:53
n10ty
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay and
tomasmik
as code owners
March 28, 2022 14:53
Guillembonet
approved these changes
Mar 29, 2022
Guillembonet
left a comment
Guillembonet
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just 2 comments. Also some parts of the code I'm not very familiar with so whoever reviews next do it carefully pls
| AccessPolicyOracleAddress: "https://trust.mysterium.network/api/v1/access-policies/", | ||
| BrokerAddresses: []string{"nats://broker.mysterium.network"}, | ||
| TransactorAddress: "https://transactor.mysterium.network/api/v1", | ||
| AffiliatorAddress: "https://affiliator.mysterium.network/api/v1", |
Contributor
There was a problem hiding this comment.
not sure about it but I think it would be nice to use just "https://affiliator.mysterium.network" in order to be able to call both v1 and v2 endpoints in case we have some in the future, maybe thats a bad choice for some reason
tomasmik
approved these changes
Apr 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.