Settlements: correct contract for beneficiary, ignore fee error on regular - #4976
Merged
Conversation
tomasmik
commented
Apr 6, 2022
tomasmik
commented
Contributor
- Don't break settlement chain if you dont have enough money for a single hermes
- Accept and use hermesID for beneficiary settlements
tomasmik
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl and
tadaskay
as code owners
April 6, 2022 07:05
Guillembonet
approved these changes
Apr 6, 2022
mdomasevicius
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.