Return whether channel is set as beneficiary or not - #4977
Merged
Conversation
Guillembonet
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl,
tadaskay and
tomasmik
as code owners
April 6, 2022 12:09
Guillembonet
force-pushed
the
beneficiary-check
branch
3 times, most recently
from
April 6, 2022 14:28
5054817 to
22bbfdd
Compare
Codecov Report
@@ Coverage Diff @@
## master #4977 +/- ##
==========================================
- Coverage 39.16% 39.09% -0.07%
==========================================
Files 359 360 +1
Lines 19093 19128 +35
==========================================
+ Hits 7477 7478 +1
- Misses 10888 10918 +30
- Partials 728 732 +4
Continue to review full report at Codecov.
|
tomasmik
reviewed
Apr 7, 2022
Guillembonet
force-pushed
the
beneficiary-check
branch
from
April 7, 2022 09:03
22bbfdd to
d1c639c
Compare
Signed-off-by: Guillem Bonet <guillem@mysterium.network>
Guillembonet
force-pushed
the
beneficiary-check
branch
from
April 7, 2022 10:34
d1c639c to
9104404
Compare
tomasmik
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do this we need the list of all hermeses, it will be fetched from observer if possible or from parameters if it fails or no url is set.
Signed-off-by: Guillem Bonet guillem@mysterium.network