Skip to content

Return whether channel is set as beneficiary or not - #4977

Merged
Guillembonet merged 1 commit into
masterfrom
beneficiary-check
Apr 8, 2022
Merged

Return whether channel is set as beneficiary or not#4977
Guillembonet merged 1 commit into
masterfrom
beneficiary-check

Conversation

@Guillembonet

Copy link
Copy Markdown
Contributor

To do this we need the list of all hermeses, it will be fetched from observer if possible or from parameters if it fails or no url is set.

Signed-off-by: Guillem Bonet guillem@mysterium.network

@Guillembonet
Guillembonet force-pushed the beneficiary-check branch 3 times, most recently from 5054817 to 22bbfdd Compare April 6, 2022 14:28
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #4977 (22bbfdd) into master (5af906e) will decrease coverage by 0.06%.
The diff coverage is 25.42%.

@@            Coverage Diff             @@
##           master    #4977      +/-   ##
==========================================
- Coverage   39.16%   39.09%   -0.07%     
==========================================
  Files         359      360       +1     
  Lines       19093    19128      +35     
==========================================
+ Hits         7477     7478       +1     
- Misses      10888    10918      +30     
- Partials      728      732       +4     
Impacted Files Coverage Δ
config/flags_node.go 9.24% <0.00%> (-0.16%) ⬇️
config/flags_observer.go 0.00% <0.00%> (ø)
core/beneficiary/saver.go 0.00% <ø> (ø)
core/node/options.go 0.00% <0.00%> (ø)
identity/registry/transactor.go 0.00% <0.00%> (ø)
mobile/mysterium/identity.go 0.00% <0.00%> (ø)
session/pingpong/hermes_promise_settler.go 33.64% <0.00%> (ø)
session/pingpong/hermes_url_getter.go 0.00% <ø> (ø)
tequilapi/contract/identity.go 0.00% <ø> (ø)
tequilapi/endpoints/identities.go 31.67% <6.89%> (-2.15%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af906e...22bbfdd. Read the comment docs.

Comment thread config/flags_observer.go Outdated
Comment thread tequilapi/endpoints/identities.go
Comment thread tequilapi/endpoints/identities.go
Signed-off-by: Guillem Bonet <guillem@mysterium.network>
@Guillembonet
Guillembonet merged commit fd81ddb into master Apr 8, 2022
@Guillembonet
Guillembonet deleted the beneficiary-check branch April 8, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants