Pass transactor errors to the caller if possible - #5144
Merged
Conversation
If possible we should pass transactor errors to the caller. This allows us to return custom errors straight from transactor if needed. For example we should be able to handle fee errors with custom `code` field. This change comes before actual new values are being returned from transactor as to no break the UI too much.
tomasmik
requested review from
Snawoot,
Waldz,
mdomasevicius,
soffokl and
tadaskay
as code owners
May 24, 2022 09:42
Guillembonet
approved these changes
May 24, 2022
n10ty
approved these changes
May 24, 2022
n10ty
approved these changes
May 25, 2022
soffokl
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If possible we should pass transactor errors to the caller.
This allows us to return custom errors straight from transactor if
needed. For example we should be able to handle fee errors with custom
codefield.This change comes before actual new values are being returned from
transactor as to no break the UI too much.
If no updated error is returned and cannot be forwarded old API errors are used, so this does not break the API.
Updates: https://github.com/mysteriumnetwork/transactor/issues/422