cli: Warn if identity not passed to registration - #518
Merged
Conversation
Currently when using the cli if a user enters the command `registration` without passing an identity they will get the obscure error: [WARNING] Something went wrong: server response invalid: 500 Internal Server Error (http://127.0.0.1:4053/identities//registration). Possible error: authentication needed: password or unlock » 1541471455617838612 [Error] [Tequilapi.Client] server response invalid: 500 Internal Server Error (http://127.0.0.1:4053/identities//registration). Possible error: authentication needed: password or unlock There is no indication in the cli that an identity must be passed to this command. We can make the user experience better by checking for the identity and explicitly warning if not present. Add warning if identity is not passed in a argument to `registration`. Signed-off-by: tcharding <me@tobin.cc>
tadovas
approved these changes
Nov 6, 2018
zolia
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when using the cli if a user enters the command
registrationwithout passing an identity they will get the obscure error:
There is no indication in the cli that an identity must be passed to
this command. We can make the user experience better by checking for
the identity and explicitly warning if not present.
Add warning if identity is not passed in a argument to
registration.With this applied we get:
Signed-off-by: tcharding me@tobin.cc