cli: Warn if unknown sub-command passed to identities - #519
Merged
Conversation
Currently if a user passes an unknown sub-command to the `identities` command we fail silently. We check for zero args and provide usage, we might as well check for incorrect args and provide usage also. This gives us `identities help` for free. Add check on the sub command for `identities` and print usage string if incorrect. Signed-off-by: tcharding <me@tobin.cc>
tadovas
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if a user passes an unknown sub-command to the
identitiescommand we fail silently. We check for zero args and provide usage, we
might as well check for incorrect args and provide usage also. This
gives us
identities helpfor free.Add check on the sub command for
identitiesand print usage string ifincorrect.
Signed-off-by: tcharding me@tobin.cc