beneficiary set with optional hermes id - #5225
Merged
Merged
Conversation
Guillembonet
requested review from
Snawoot,
Waldz,
mdomasevicius,
n10ty,
soffokl,
tadaskay and
tomasmik
as code owners
June 20, 2022 07:39
n10ty
approved these changes
Jun 20, 2022
tomasmik
approved these changes
Jun 20, 2022
tomasmik
left a comment
tomasmik
left a comment
Contributor
There was a problem hiding this comment.
I assume this still requires the nodeUI changes or else it's gonna break again.
Signed-off-by: Guillem Bonet <guillem@mysterium.network>
Guillembonet
force-pushed
the
optional-hermes-id
branch
from
July 6, 2022 09:32
ae6193e to
3cf1ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hermes id is now fully optional, if none is provided it will use the one with the most unsettled funds.
Signed-off-by: Guillem Bonet guillem@mysterium.network